Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effectful custom DNS resolution in blaze client #707

Open
ghost opened this issue Mar 3, 2022 · 4 comments
Open

Effectful custom DNS resolution in blaze client #707

ghost opened this issue Mar 3, 2022 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 3, 2022

Make Http1Support.getAddress and BlazeClientBuilder.customDnsResolver: RequestKey => F[Either[Throwable, InetSocketAddress]]. The usage in makeClient is already effectful.

@rossabaker
Copy link
Member

The customDnsResolver is going to be tricky to do in a bincompat fashion, but it seems like the right thing to do. Are you aiming for 1.0, or do you need this in 0.23?

@armanbilge
Copy link
Member

armanbilge commented Mar 7, 2022

It'll be slightly hacked but we can do this bincompatibly by leveraging type erasure.

Edit: nvmd, spoke too soon. It's exposed as a public val in the builder so that won't work.

@rossabaker
Copy link
Member

I think we could deprecate the val and the current setter. If the setter is called, the function could be lifted.

@armanbilge
Copy link
Member

This should be migrated I think, along with a few other issues that have been labelled since the schism.

@rossabaker rossabaker transferred this issue from http4s/http4s Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants