Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md example does not work #1

Open
aenglander opened this issue Jan 6, 2016 · 1 comment
Open

README.md example does not work #1

aenglander opened this issue Jan 6, 2016 · 1 comment

Comments

@aenglander
Copy link
Contributor

The following errors occur attempting to use the example code in the README.md:

  • Client error: Call to a member function write() on unknown.
  • Fatal error: Uncaught TypeError: Argument 1 passed to {closure}() must be an instance of Exception, instance of Error given in ...
@trowski
Copy link
Contributor

trowski commented Jan 6, 2016

Thanks for catching my typos. I've fallen behind on updating the examples because I'm preparing more complete docs that will be hosted on icicle.io. You can view them now at http://icicleio.github.io/docs and contribute at https://github.com/icicleio/docs.

The TypeError was being thrown because an Error was thrown from $client being undefined. Otherwise Exception is correct for PHP 5.x. It could be changed to Throwable for PHP 7. The docs will be split into v1.x for PHP 5.x and v2.x for PHP 7, so this should be less of a problem going forward.

trowski pushed a commit that referenced this issue May 17, 2016
Fix the README.md example for issue #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants