Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from agm to ng-maps #175

Open
alanorth opened this issue Jul 10, 2023 · 2 comments
Open

Migrate from agm to ng-maps #175

alanorth opened this issue Jul 10, 2023 · 2 comments
Labels
enhancement New feature or request P-low Low priority

Comments

@alanorth
Copy link
Member

agm is abandoned and causes issues during npm install due to conflicting dependencies. You must use npm install --force to install. We should migrate to ng-maps.

agm also causes this warning during build:

Warning: /home/aorth/src/git/OpenRXV/frontend/src/app/explorer/explorer.module.ts depends on '@agm/snazzy-info-window'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
@alanorth alanorth added enhancement New feature or request P-low Low priority labels Jul 10, 2023
@alanorth
Copy link
Member Author

@mohammadsalem are you still using the maps feature in WOCAT? We don't use it at all and it causes these errors during build.

@mohammadsalem
Copy link
Collaborator

@alanorth yes it is still used for WOCAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanorth @mohammadsalem