Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSN credit-based shaper should be able to compensate for closed gate intervals in the corresponding time-aware shaper #874

Open
levy opened this issue Mar 23, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@levy
Copy link
Contributor

levy commented Mar 23, 2023

I have found another feauture, that might be interesting to be added to the current CBS implementation to match the IEEE 802.1Q-2018 standart.

In the CBS chapter 8.6.8.2 d.) on page 201 there is a note that when using CBS +TAS the idleslope has to be increased by a certain factor that compensates the closed gate intervals by a weighting factor to keep the effective datarate that the user assignes to traffic shaped by the CBS.

In the current implementation for example if the user assignes 50Mbit/s and the AVB gate is closed 50% of the time (due to TAS operation), the resulting effective data rate would be 25Mbit/s.
This could be solved by adding a weighting factor to the idleCreditGainRate.

idleCreditGainRateCompensated = idleCreditGainRate * (OperCycleTime / GateOpenTime)

Where OperCycleTime is the hyperperiod of the GCL and GateOpenTime the respective overall gate open duration per GCL cycle

grafik

Originally posted by @PhilippComet in #848 (comment)

@levy levy self-assigned this Mar 23, 2023
@levy levy added the Feature label Mar 23, 2023
@levy levy added this to the Postponed milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant