Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of minimum NASM version from 2.14 to 2.16 #117

Open
tkanteck opened this issue Feb 10, 2023 · 3 comments
Open

Update of minimum NASM version from 2.14 to 2.16 #117

tkanteck opened this issue Feb 10, 2023 · 3 comments
Labels
Announcement Information about upcoming changes

Comments

@tkanteck
Copy link
Contributor

For the time being, build system has been updated to work with NASM 2.14 and 2.16 producing different binaries and delivering different performance levels on some hardware platforms.

Going forward, in order to produce binary with consistent performance and use required instructions it will be necessary to change minimum required NASM version from 2.14 to NASM 2.16

@tkanteck tkanteck added the Announcement Information about upcoming changes label Feb 10, 2023
@tkanteck
Copy link
Contributor Author

tkanteck commented Apr 8, 2024

The next release will require NASM 2.16.02

If there are any potential problems with it then please let us know here

@riveridea
Copy link

Can I know what could be impacted if my NASM is 2.15.3 while I see this warning:
NASM 'nasm' version: 2.15.03
Makefile:102: Minimum required NASM version for AVX-IFMA: 2.16. AVX-IFMA code not compiled - update NASM.

@tkanteck
Copy link
Contributor Author

tkanteck commented Oct 3, 2024

AVX-IFMA is only used for POLY1305 in the library.
There is only performance impact. AVX-IFMA based POLY1305 implementation is faster.
There is no impact as long as:

  • poly1305 is not used or its performance is not critical
  • platform being used doesn't support AVX-IFMA instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Announcement Information about upcoming changes
Projects
None yet
Development

No branches or pull requests

2 participants