Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkInterface Detachment Failure #152

Open
so-sahu opened this issue Feb 5, 2024 · 1 comment
Open

NetworkInterface Detachment Failure #152

so-sahu opened this issue Feb 5, 2024 · 1 comment
Labels
bug Something isn't working prio-high

Comments

@so-sahu
Copy link
Contributor

so-sahu commented Feb 5, 2024

Describe the bug
The NetworkInterface detachment process is not functioning as expected. After attempting to detach a NetworkInterface, it is successfully removed from the store but remains present in the DomainXML.

To Reproduce

  1. Create a machine with nic.
  2. Detach the nic.
  3. Verify domain machine DomainXML. nic is not getting removed.

Expected behavior
The NetworkInterface should be successfully unplugged from both the store and the DomainXML.

Screenshots

2024-02-05T06:44:55Z	ERROR	machine-reconciler	failed to reconcile machine	{"machineID": "0c058844-7cb9-42a6-b988-d6573f870551", "error": "[network interfaces] attach / detach error(s): [[network interface primary] error detaching: internal error: unable to execute QEMU command 'device_del': Device ua-networkinterface-primary is already in the process of unplug]"}
github.com/ironcore-dev/libvirt-provider/pkg/controllers.(*MachineReconciler).processNextWorkItem
	/home/sosahu/my-workspace/libvirt-provider/UT/store/libvirt-provider/pkg/controllers/machine_controller.go:300
github.com/ironcore-dev/libvirt-provider/pkg/controllers.(*MachineReconciler).Start.func7
	/home/sosahu/my-workspace/libvirt-provider/UT/store/libvirt-provider/pkg/controllers/machine_controller.go:200
@so-sahu so-sahu added the bug Something isn't working label Feb 5, 2024
@Rohit-0505 Rohit-0505 self-assigned this Feb 9, 2024
@lukas016
Copy link
Contributor

lukas016 commented Feb 9, 2024

@Rohit-0505 we will have probably wrong logic for manage status of nics. We have similar issue for volume: #144

You can inspire by my PR

@Rohit-0505 Rohit-0505 removed their assignment Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio-high
Projects
Status: Todo
Development

No branches or pull requests

4 participants