Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple libvirt-provider instances share same storage #198

Open
lukas016 opened this issue Feb 21, 2024 · 1 comment
Open

multiple libvirt-provider instances share same storage #198

lukas016 opened this issue Feb 21, 2024 · 1 comment

Comments

@lukas016
Copy link
Contributor

Problem description

Current implementation of store uses filesystem for storage api.Machine objects. We are using mutex for avoid of race condition during modified api.Machine. But we don't have any protection between running multiple instances of libvirt-provider.

It can create race condition during upgrade of libvirt-provider, when multiple instances of libvirt-provider run simultaneously.

I think we need to fix this special case. One of possible solution is use lock base on file (same logic as flock). Maybe: https://pkg.go.dev/github.com/theckman/go-flock

What do you think?

@lukas016 lukas016 added question Further information is requested prio-low labels Feb 21, 2024
@lukas016
Copy link
Contributor Author

lukas016 commented Apr 10, 2024

we decided only one instance of pod can run at the time.

@lukas016 lukas016 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@lukas016 lukas016 reopened this Apr 10, 2024
@lukas016 lukas016 added prio-high and removed question Further information is requested prio-low labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant