Request: close outdated issues

[thomasjm]

Thanks for the great library!

I was wondering if it would be possible to close some of the outstanding issues on this library if they're believed to have been solved. There are a number of scary-looking outstanding issues, such as

#72
#124
#194

but when I look at these it seems like PRs have already been merged to fix them.

There are also some random bug and feature requests going all the way back to 2011. All together, these issues make it hard to look at the issue tracker and see what is actually a real issue/priority that I should worry about when using this library.

[jaspervdj]

Thanks! You're absolutely right, I would need to do a major cleanup of the open issues/PRs, but I've unfortunately been a bit to busy to track that well (and it doesn't seem to get better). The three issues you linked were indeed all solved; thanks for pointing that out, and I appreciate that you took the time to help dig these up and close them!

[thomasjm]

No problem! FYI those came from just a cursory search through the issues -- I'd be happy to go through the rest and see if anything else looks ready to close.

[thomasjm]

Here's the first batch:

Appears to be already solved by a PR:

#85
#129

Super old/probably no longer relevant:

#80

Long time with no response from originator:

#117
#139 (nothing actionable remaining?)

Solved by originator

#142
#146 (?)
#188 (?)

Misc

#135: I think this one was solved by PR #191

#136 and #120 can be merged

#143 is possibly done? not sure, please take a look

#174 seems like it can be combined with #159

[jaspervdj]

Thank you so much @thomasjm! I was able to close most of these and added comments to others. I'm currently vacationing in Mexico but will try to do another pass soon.

[domenkozar]

This can be closed now.