-
-
Notifications
You must be signed in to change notification settings - Fork 16
Sample data expanded with images and headings h1 #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR succesfully
There are 2 things which should be checked and if possible improved:
Possible solution: Switch off article title display in the menu item's options (not in the article options because we still might want to see the article's title in blog views) so only the h1 page heading is shown. I haven't seen this problem on other pages.
Possible solution same as above, hide (article) title and show page heading in menu item options. |
@richard67 I fixed the h1 issue for headings in single articles. |
@chmst I can't confirm that. I still have both issues I described in my comment above . |
@chmst Have you checked my previous comment? |
I am not quite sure abot these changes. Please do not merge |
@chmst If you wanna be sure it's not merged, go back to draft status. |
@chmst Meanwhile this PR will have merge conflicts with the development branch as soon as you set it to "Ready for review". Is this PR here still relevant? Or has it become obsolete meanwhile? |
As it is mainly for switches in params and as we have no design decisions, I can close it. Thank you for remembering me |
Pull Request for Issue #124 .
Summary of Changes
Testing Instructions
Apply sample data in a fresh installation of cassiopeia
Expected result
All pages have a heading h1
Actual result
The Homepage has H1 but other pages start with h2
Note
show_page_heading is a param in the menuItem. This means: Articles which are shown with direct link and not from the menu still have header tag 2.