Skip to content
This repository has been archived by the owner on Jan 25, 2021. It is now read-only.

Sample data expanded with images and headings h1 #147

Closed
wants to merge 29 commits into from

Conversation

chmst
Copy link
Collaborator

@chmst chmst commented Sep 28, 2020

Pull Request for Issue #124 .

Summary of Changes

Testing Instructions

Apply sample data in a fresh installation of cassiopeia

Expected result

All pages have a heading h1

Actual result

The Homepage has H1 but other pages start with h2

Note

show_page_heading is a param in the menuItem. This means: Articles which are shown with direct link and not from the menu still have header tag 2.

Copy link
Collaborator

@drmenzelit drmenzelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR succesfully

@richard67
Copy link
Member

richard67 commented Sep 28, 2020

There are 2 things which should be checked and if possible improved:

  1. At page "Home / About" we have a h1 page heading and a h2 article heading with the same text. That looks silly.

2020-09-28_1

Possible solution: Switch off article title display in the menu item's options (not in the article options because we still might want to see the article's title in blog views) so only the h1 page heading is shown.

I haven't seen this problem on other pages.

  1. In the single article views below "Home / Sample Layouts / Articles", the article title is shown as h2 heading, and there is no h1 heading. Example for the first of the 3 articles:

2020-09-28_2

Possible solution same as above, hide (article) title and show page heading in menu item options.

@chmst chmst changed the title Change show-page-heading to "yes" Sample data expanded with images and headings h1 Sep 29, 2020
@chmst
Copy link
Collaborator Author

chmst commented Oct 2, 2020

@richard67 I fixed the h1 issue for headings in single articles.

@richard67
Copy link
Member

@richard67 I fixed the h1 issue for headings in single articles.

@chmst I can't confirm that. I still have both issues I described in my comment above .

@richard67
Copy link
Member

@richard67 I fixed the h1 issue for headings in single articles.

@chmst I can't confirm that. I still have both issues I described in my comment above .

@chmst Have you checked my previous comment?

@chmst
Copy link
Collaborator Author

chmst commented Oct 19, 2020

I am not quite sure abot these changes. Please do not merge

@richard67
Copy link
Member

@chmst If you wanna be sure it's not merged, go back to draft status.

@chmst chmst marked this pull request as draft October 19, 2020 14:05
@richard67
Copy link
Member

@chmst Meanwhile this PR will have merge conflicts with the development branch as soon as you set it to "Ready for review". Is this PR here still relevant? Or has it become obsolete meanwhile?

@chmst
Copy link
Collaborator Author

chmst commented Oct 24, 2020

As it is mainly for switches in params and as we have no design decisions, I can close it. Thank you for remembering me

@chmst chmst closed this Oct 24, 2020
@richard67 richard67 deleted the sample-data-menuitem-alias branch October 24, 2020 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants