Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP: probes clustering on the map #635

Open
MartinKolarik opened this issue Jun 17, 2024 · 6 comments
Open

GP: probes clustering on the map #635

MartinKolarik opened this issue Jun 17, 2024 · 6 comments

Comments

@MartinKolarik
Copy link
Member

MartinKolarik commented Jun 17, 2024

I noticed the coordinates we're getting from geoip providers are very low quality and tend to put all probes in the area in a single place. E.g. this changes to this when zooming, which is 1 probe on the left, and 17 probes stacked over each other on the right. In some other cases, it results in formations like this.

We have a somewhat related task jsdelivr/globalping#306 (this question is about UI, but it might create new requirements in that task), and I'm wondering what's even the best way of presenting these on the map:
a) slightly moving the dots so that each individual probe is visible (similar to the last screenshot),
b) forcing the cluster view and always showing a single node with the number,
c) something else?

I think B makes the most sense (with 20 dots, you aren't going to click each of them to see the details anyway), and it allows for the most efficient API responses, but it opens the question of what to do about tooltips with network names - do we just not show them for these clusters? Do we show a big tooltip with all network names?

@jimaek @alexey-yarmosh

@jimaek
Copy link
Member

jimaek commented Jun 18, 2024

I don't want to force the cluster view, I want people to be able to view each individual dot and metadata. So option 1 sounds best

@MartinKolarik
Copy link
Member Author

But does that option really work for what you want? If I see 20 probes in one location, I really won't be clicking each of them. It gets boring very quickly. If we show a single big cluster, we can also show all information combined in a single tooltip, which seems better.

@jimaek
Copy link
Member

jimaek commented Jun 19, 2024

I personally often use it and zoom all the way to the dots to better understand what is going on and where exactly is probe is. Just having "20 probes in this general direction" is not very nice or precise.

@MartinKolarik
Copy link
Member Author

But we're talking specifically about the case where all probes are in the same location anyway. If the coordinates were different, we would still show them separately.

@jimaek
Copy link
Member

jimaek commented Jun 19, 2024

How would the tooltip look in that case? There are instances of 20 probes in the same coordinates

@MartinKolarik
Copy link
Member Author

That's up to Robert to figure out but I think it might work. I can ask him for a preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants