Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click to show page preview #172

Open
amivaleo opened this issue Apr 24, 2020 · 4 comments
Open

Double click to show page preview #172

amivaleo opened this issue Apr 24, 2020 · 4 comments

Comments

@amivaleo
Copy link
Contributor

Hi!

Each page loaded in Slicer has a hidden "preview" button which appears on hovering.

Since hovering is not possible on touch devices, can you please consider to allow to trigger that very same action by double-clicking on the page thumbnail?

I believe it might come in handy also for the traditional mouse&keyboard UX since the thumbnail offers a larger area for interaction than the hidden button. Also, it might be slightly quicker maybe.

⚠: the double-click should not toggle the page selection.

@junrrein
Copy link
Owner

Hi there! I completely agree with your reasoning, on all items. This should get done.

Thanks for the report!

@Vanadiae
Copy link

It is not a very discoverable behavior as described under General guidelines. It would be rather more logical to just always show this preview button.

@amivaleo
Copy link
Contributor Author

amivaleo commented Apr 24, 2020

It is not a very discoverable behavior as described under General guidelines. It would be rather more logical to just always show this preview button.

Yes, I'm aware of that. Me and Julian talked already about this "preview window" and how to make it available in the UI to touch devices (here: #30 (comment) ). I actually tried to convince him to get rid of that entirely. As you can see, I failed. 😄

So yes, the UI for this action is still a open issue. Please, if you have any suggestion, simply tell us. I can't figure this one out.

@junrrein
Copy link
Owner

@Vanadiae You make a good point, and I'm aware of that issue. And @amivaleo is right with the history lol.

I've created #179 so we have a separate place to talk about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants