From f974efe5c6b6377656f4e8bb6554248bc37db90a Mon Sep 17 00:00:00 2001 From: Ben Mares Date: Thu, 11 Nov 2021 23:47:10 +0100 Subject: [PATCH] Fix apparent logic error in _log Make noise when JUPYTER_DOCKER_STACKS_QUIET is empty --- base-notebook/start.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/base-notebook/start.sh b/base-notebook/start.sh index 6cba9e9505..0e7f9032b2 100755 --- a/base-notebook/start.sh +++ b/base-notebook/start.sh @@ -8,7 +8,7 @@ set -e # always log errors and warnings, but can be silenced by setting # JUPYTER_DOCKER_STACKS_QUIET. _log () { - if [[ "$*" == "ERROR:"* ]] || [[ "$*" == "WARNING:"* ]] || [[ "$JUPYTER_DOCKER_STACKS_QUIET" != "" ]]; then + if [[ "$*" == "ERROR:"* ]] || [[ "$*" == "WARNING:"* ]] || [[ "$JUPYTER_DOCKER_STACKS_QUIET" == "" ]]; then echo "$@" fi } @@ -207,7 +207,6 @@ else # NOTE: This hook is run as the user we started the container as! run-hooks /usr/local/bin/before-notebook.d - unset_explicit_env_vars _log "Executing the command:" "${cmd[@]}" exec "${cmd[@]}" fi