feat: in declare_v1 transaction, compute class_hash from contract_class

[Eikix]

Feature Request

In starknet pallet, declare v1, we currently accept the contract class hash as part of the payload.
It'd be sounder to compute it inside the declare v1 scope.

As per: https://docs.starknet.io/documentation/architecture_and_concepts/Blocks/transactions/#declare_v1, user does need to provide the class hash (otherwise we'd need to check it matches the contract class, thus recomputing it)

Describe the Feature Request

From the ContractClass struct, create a method called compute_class_hash that takes a non mutable ref to self and returns the class_hash as per declare v1 -> https://docs.starknet.io/documentation/architecture_and_concepts/Contracts/class-hash/

[Eikix]

Additional comment, if test PR is done -> update declare tests to not include contract class hash anymore

[Eikix]

Current sequencer -> https://github.com/starkware-libs/blockifier/blob/3df4bc49a0e2f3c442137fedd11acbd560cfef92/crates/blockifier/src/transaction/account_transactions_test.rs#L69

[Eikix]

Open RPC spec -> https://github.com/starkware-libs/starknet-specs/blob/47727a8f2332c762b93d4acbd07e06bfe78bcf94/api/starknet_api_openrpc.json#L1426

[marioiordanov]

Those changes have a PR starkware-libs/starknet-api#42.

[marioiordanov]

I want to work on this issue

[EvolveArt]

Those changes have a PR starkware-libs/starknet-api#42.

Hello @marioiordanov ! Great to see your PR making progress on their repo! Do you think you'd be able to tackle this one next which should be quite straightforward once your PRs merged in starknet-api

[marioiordanov]

Hello @EvolveArt not sure, when the PR is going to be merged. Also I see that Madara is using a fork of the starknet_api, which I can't tell how often is being synced with the starknet_api repo. Aside from that I think it would be easy to be implemented.

[EvolveArt]

Not sure, when the PR is going to be merged. Also I see that Madara is using a fork of the starknet_api, which I can't tell how often is being synced with the starknet_api repo. Aside from that I think it would be easy to be implemented.

Great, well will check that and try to push for it to be merged

[AbdelStark]

@marioiordanov @EvolveArt can we move forward on this ? even if not merged in starknet_api I mean ?

[marioiordanov]

@abdelhamidbakhta you mean to move the implementation from starknet_api to the Madara project, or make the changes to starknet-api fork of tdelabro

[AbdelStark]

@abdelhamidbakhta you mean to move the implementation from starknet_api to the Madara project, or make the changes to starknet-api fork of tdelabro

I mean make the changes to starknet-api fork of tdelabro

[EvolveArt]

@abdelhamidbakhta you mean to move the implementation from starknet_api to the Madara project, or make the changes to starknet-api fork of tdelabro

I mean make the changes to starknet-api fork of tdelabro

Ok @marioiordanov can you make your PR to the fork so we can finish this ?

[marioiordanov]

@abdelhamidbakhta you mean to move the implementation from starknet_api to the Madara project, or make the changes to starknet-api fork of tdelabro

I mean make the changes to starknet-api fork of tdelabro

Ok @marioiordanov can you make your PR to the fork so we can finish this ?

@EvolveArt yeah sure, please assign it to myself

[AbdelStark]

@abdelhamidbakhta you mean to move the implementation from starknet_api to the Madara project, or make the changes to starknet-api fork of tdelabro

I mean make the changes to starknet-api fork of tdelabro

Ok @marioiordanov can you make your PR to the fork so we can finish this ?

@EvolveArt yeah sure, please assign it to myself

Assigned it to you

[github-actions]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!