Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Ignore cached flag when hashing outpoint #233

Open
m-kus opened this issue Oct 2, 2024 · 3 comments
Open

[dev] Ignore cached flag when hashing outpoint #233

m-kus opened this issue Oct 2, 2024 · 3 comments
Assignees

Comments

@m-kus
Copy link
Collaborator

m-kus commented Oct 2, 2024

Context

Currently TxOut contains cached field which is a hint that tells the client this output will be spent within the same block it is created. Since OutPoint includes TxOut it contributes to the outpoint hash, which becomes a leaf in the Utreexo accumulator. However, the Utreexo node cannot provide this hint (easily), and generally speaking it is not part of the data (it is a hint).

Task

  • Add custom implementation of the Hash trait for TxOut to exclude cached field
  • Update data generation scripts accordingly
  • Regenerate integration tests for utreexo

Depends on #229 (should be merged first)

@mubarak23
Copy link
Contributor

mubarak23 commented Oct 2, 2024

@m-kus i like to take this

Kindly assign

Thank you

@PavitraAgarwal21
Copy link
Contributor

@m-kus Can I take this

@m-kus m-kus added blocked Requires other issues to be resolved first and removed blocked Requires other issues to be resolved first labels Oct 2, 2024
@baitcode
Copy link

baitcode commented Oct 3, 2024

I'd love to work on this. If it's still available, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants