Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The in-cluster-sender error should be debuggable #129

Open
cardil opened this issue Dec 22, 2021 · 3 comments
Open

The in-cluster-sender error should be debuggable #129

cardil opened this issue Dec 22, 2021 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Milestone
Stable release (GA)

Comments

@cardil
Copy link
Contributor

cardil commented Dec 22, 2021

Currently, the following code is used when the in-cluster-sender fails to send the event.

https://github.com/knative-sandbox/kn-plugin-event/blob/6d85cfd3588b76bebb2a05b5d345c4eb4a468e21/pkg/k8s/jobrunner.go#L81-L82

This doesn't allow telling the end user what actually has happened. A proper report should be built, by dumping sender job' pods YAMLs, and their logs. Such report should be saved as a file (in user home) and file path to it should be provided to the console.

/kind bug
@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2021
@cardil cardil mentioned this issue Dec 22, 2021
Closed
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 23, 2022
cardil added a commit to cardil/kn-plugin-event that referenced this issue Mar 31, 2022
@cardil
[1.2] Backport of knative-extensions#129
4811b3d 
 * [1.1] Backport of knative-extensions#85

   - knative-sandbox#126
   - Parts of knative-extensions/reconciler-test#284
   - knative-sandbox#146
   - knative-sandbox#159

 * [1.1] Backport of knative-extensions#100

   - knative-extensions#168
   - openshift-knative#99
@cardil
Copy link
Contributor Author

cardil commented Apr 26, 2022

/remove-lifecycle stale
/reopen

@knative-prow knative-prow bot reopened this Apr 26, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 26, 2022

@cardil: Reopened this issue.

In response to this:

/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2022
@cardil cardil added the triage/accepted Issues which should be fixed (post-triage) label Apr 26, 2022
@cardil cardil mentioned this issue Jul 19, 2022
Closed
@cardil cardil added this to the Stable release (GA) milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
Stable release (GA)
Development

No branches or pull requests
2 participants
@cardil @knative-prow-robot