Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with containedctx linter #202

Open
cardil opened this issue Jul 19, 2022 · 5 comments · May be fixed by #368
Open

Comply with containedctx linter #202

cardil opened this issue Jul 19, 2022 · 5 comments · May be fixed by #368
Assignees
@cardil
Labels
good first issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Issues which should be fixed (post-triage)

Comments

@cardil
Copy link
Contributor

cardil commented Jul 19, 2022 •
edited
Loading

The containedctx linter is being included within golangci-lint. We should make the code comply with this linter.

Violations:

pkg/k8s/addressresolver.go:39:2: found a struct that contains a context.Context field (containedctx)
	ctx  context.Context
	^
pkg/k8s/kubeclient.go:105:2: found a struct that contains a context.Context field (containedctx)
	ctx       context.Context
	^
pkg/tests/fakeclients.go:33:2: found a struct that contains a context.Context field (containedctx)
	ctx       context.Context
	^
@cardil cardil added good first issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 19, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2022
@cardil
Copy link
Contributor Author

cardil commented Oct 19, 2022

/remove-lifecycle stale
/triage accepted

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2022
@xiangpingjiang
Copy link

/assign

@aliok
Copy link
Member

aliok commented May 22, 2024

/unassign xiangpingjiang

@cardil
Copy link
Contributor Author

cardil commented Sep 20, 2024

/assign

@cardil cardil linked a pull request Sep 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cardil cardil

Labels
good first issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

💝 Migrating to sink flag for --to param cardil/kn-plugin-event
3 participants
@aliok @cardil @xiangpingjiang