-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically create Helm index.yaml file for new release #1851
Comments
@houshengbo what are your thoughts on this? |
@kromanow94 I like this approach of creating index.yaml for the Helm charts. I was looking for the solution, but did not figure out. One remark I have is that right now, all knative projects are using ./hack/release.sh and ./hack/generate-yamls.sh to generate the artifacts for releases. Try to put the code related to releases in there. And, do we have to use python? Shall we use script or even golang for https://github.com/kromanow94/knative-operator/blob/main/find_helm_chart_releases_and_create_helm_index.py? Just want to consistent with current source code. |
Hey, I created a new script using bash. Please see the script here find_helm_chart_releases_and_create_helm_index.sh. I also changed the app version formatting to standardize the format to This is now the new representation of the Helm Chart Repository in
WDYT? |
This is a continuation of my comments under #1525.
Problem
The
knative-operator
is not released to any Helm Chart Repository. The Helm Charts exist in the artifacts but there is no Helm Chart Repository forknative-operator
.The simplest way of providing a Helm Chart Repository is to provide an
index.yaml
file directly to the git repository and use it with the raw url format.Assuming the
index.yaml
file would exist in themain
branch of this repository, the Helm Chart Repository URL would be:I already created a PoC for this in my fork:
If this approach is accepted, I can contribute and create a PR with the script and GH Workflow that will execute this script and commit changes to the
main
branch.Persona:
System Operator
Exit Criteria
When a new Helm Chart is released with the knative-operator releases, the
index.yaml
should be automatically updated with new release of Helm Chart. This can be achieved with the GitHub Action Workflow and a slightly modified script available here: kromanow94/knative-operator/find_helm_chart_releases_and_create_helm_index.py. The script modification requires only to get the GitHub Token as shown in example here: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow.Time Estimate (optional):
1-3 days, depending on the feedback.
The text was updated successfully, but these errors were encountered: