Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metric lint check fails #3

Open
karlism opened this issue Oct 8, 2019 · 0 comments
Open

Prometheus metric lint check fails #3

karlism opened this issue Oct 8, 2019 · 0 comments

Comments

@karlism
Copy link

karlism commented Oct 8, 2019

Hello,

Running promtool check metrics against latest version of ping exporter:

$ curl -s http://exporter:9346/ping?target=example | promtool check metrics
ping_packets_total non-counter metrics should not have "_total" suffix
ping_times_max no help text
ping_times_min no help text
$ promtool --version
promtool, version 2.13.0 (branch: HEAD, revision: 6ea4252299f542669aca11860abc2192bdc7bede)
  build user:       root@f30bdad2c3fd
  build date:       20191004-11:25:34
  go version:       go1.13.1

It is also generally recommended to report time in seconds, instead of milliseconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant