Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exoflex: carousel #47

Open
oshimayoan opened this issue Sep 3, 2019 · 5 comments
Open

exoflex: carousel #47

oshimayoan opened this issue Sep 3, 2019 · 5 comments
Assignees

Comments

@oshimayoan
Copy link
Contributor

oshimayoan commented Sep 3, 2019

Discussion for Multi-platform Carousel component.

@nathaniaelvina
Copy link
Contributor

nathaniaelvina commented Oct 23, 2019

The question is, how much flexibility do we want to give the user to customize the carousel?

Props react-native-web-swiper react-native-sideswipe react-native-snap-carousel
supports mobile & web mobile only mobile only
content offset -
slide vertical & horizontal
button prev & next - -
able to move page indicator to flexible position only inside positioning - -
snap TBA TBA TBA

Positioning should able to fullfil this condition, i guess?
Screen Shot 2019-10-23 at 4 05 30 PM

@oshimayoan
Copy link
Contributor Author

oshimayoan commented Oct 24, 2019

Woah, that table and image are really helpful!

From the table above, I would like to vote for react-native-web-swiper. But, is that - symbol means not supported?

If yes, it's completely a win for react-native-web-swiper, don't you think?
They have support for web, prev & next button, and flexible page indicator (even though it's only for the inside position). Indeed, they do not have content offset supports yet, but is that really needed?

@nathaniaelvina
Copy link
Contributor

But, is that - symbol means not supported?

yes, - means not supported.

and flexible page indicator (even though it's only for the inside position).

or we build our own pagination.

Indeed, they do not have content offset supports yet, but is that really needed?

i think so (?)
Screen Shot 2019-10-24 at 4 03 00 PM

@oshimayoan
Copy link
Contributor Author

Yeah, we could make use of their onIndexChanged prop to build our own pagination.

@oshimayoan oshimayoan modified the milestone: exoflex v3.2.0 Feb 6, 2020
@oshimayoan
Copy link
Contributor Author

After internal discussion, we made a conclusion to build this from scratch.

The feature will be:

  • Looping but without transition
  • Snapable on mobile (both native and web)
  • Clickable dot pagination on desktop web
  • Able to change arrow styling and position
  • No offset for now
  • Expose Animated.Value>
  • Receive dot pagination as component from props

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants