Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.10 #564

Closed
tomjaguarpaw opened this issue May 11, 2024 · 6 comments
Closed

Support GHC 9.10 #564

tomjaguarpaw opened this issue May 11, 2024 · 6 comments

Comments

@tomjaguarpaw
Copy link
Collaborator

Initial conversion to GHC 9.10 is on branch 9.10. Test it with

cabal test -w ghc-9.10 --allow-newer

There are a number of test failures, so I suspect that the GHC API format has changed again :(


Any volunteers to take this on? @0rphee, would you be interested?

@0rphee
Copy link
Contributor

0rphee commented May 13, 2024

I'm busy with school (approaching finals), so I'm afraid it would have to wait for a ~month (+/-)... :(

@tomjaguarpaw
Copy link
Collaborator Author

OK, no problem. Let's see if anyone else picks it up in the meantime. Good luck with finals!

@tomjaguarpaw
Copy link
Collaborator Author

This branch seems to work. It needs CPP in order to enable the changes for 9.10 only.

https://github.com/kowainik/stan/tree/9.10

@philderbeast
Copy link
Contributor

I gave stan an Updo conversion and have it building there, at up-do/stan. I haven't tackled the test failures.

The conversion was interesting, see cabalism/updo#41. I went with a ghc-9.10.1 Stack resolver.

GHC_VERSION ?= 9.10.1
STACKAGE_VERSION ?= ghc-9.10.1

@tomjaguarpaw
Copy link
Collaborator Author

The test failures for 9.10 are fixed by my branch (see above), but it needs some CPP to make those changes only on 9.10.

@tomjaguarpaw
Copy link
Collaborator Author

After 09b1c66 we support 9.10. There's still one thing to be taken care of though: #572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants