Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero value for Sleep Action of PreStop Hook #4818

Open
4 tasks
sreeram-venkitesh opened this issue Aug 31, 2024 · 5 comments
Open
4 tasks

Allow zero value for Sleep Action of PreStop Hook #4818

sreeram-venkitesh opened this issue Aug 31, 2024 · 5 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone

Comments

@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Aug 31, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 31, 2024
@sreeram-venkitesh
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 31, 2024
@kubernetes kubernetes deleted a comment Aug 31, 2024
@kubernetes kubernetes deleted a comment Aug 31, 2024
@kubernetes kubernetes deleted a comment Aug 31, 2024
@kubernetes kubernetes deleted a comment Aug 31, 2024
@sreeram-venkitesh sreeram-venkitesh self-assigned this Sep 3, 2024
@SergeyKanzhelev
Copy link
Member

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 24, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 24, 2024
@kannon92
Copy link
Contributor

Based on @SergeyKanzhelev comments, I think we can move this to be "Considered For Release".

@impact-maker
Copy link
Member

impact-maker commented Oct 1, 2024

Hello @sreeram-venkitesh 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • KEP has a production readiness review that has been merged into k/enhancements.
    The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@sreeram-venkitesh
Copy link
Member Author

Thanks @impact-maker, the enhancements PR is already reviewed by the PRR team, I will resolve the comments and get it merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Status: At risk for enhancements freeze
Status: Considered for release
Development

No branches or pull requests

5 participants