Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with android facebook #36

Open
Stiofan opened this issue Jul 8, 2015 · 17 comments
Open

Not working with android facebook #36

Stiofan opened this issue Jul 8, 2015 · 17 comments

Comments

@Stiofan
Copy link

Stiofan commented Jul 8, 2015

added text, image and url and when i click facebook nothing appears, it's just a new blank post.

@leecrossley
Copy link
Owner

Facebook message text for android is no longer possible, you can share a url or an image but not both. This is a limitation imposed by Facebook, not the plugin.

@Stiofan
Copy link
Author

Stiofan commented Jul 9, 2015

So what is the one that breaks it? Can you not tell the script to only give FB the url and ignore the text because at the moment it tries to share nothing.

@loicfavory
Copy link
Collaborator

You have to modify the plugin to deal with Facebook.
If you're sharing an Intent with Facebook, you have to pass the URL in the Intent.EXTRA_TEXT

It's possible, I did it for one of my apps : https://github.com/loicfavory/cordova-plugin-social-message

@leecrossley
Copy link
Owner

Can you clean and PR the modification @loicfavory?

@loicfavory
Copy link
Collaborator

@leecrossley I'm very busy this summer, but I'll try to find some time this week end to do it. Did you check my code to see what I did ?

@leecrossley
Copy link
Owner

OK, I'll see if I can pull it across tomorrow - thanks

@leecrossley leecrossley reopened this Jul 9, 2015
@loicfavory
Copy link
Collaborator

Not sure you can pull without cleaning it. I did a lot of specifics dev for my project.

@leecrossley
Copy link
Owner

Yes, of course. I will just take the relevant parts, pull was probably the wrong choice of word - thanks for helping out.

@loicfavory
Copy link
Collaborator

ok, I'm sorry, it's not well commented. Ask me if you need help but I'll not have a lot of time before saturday

@Stiofan
Copy link
Author

Stiofan commented Jul 9, 2015

Hopefully this gets added before my release, thanks for the help both of you :)

@leecrossley
Copy link
Owner

so, are we saying that now we can only share a URL for Facebook Android? Your fork seems to suggest you ignore the other parameters in the case of Facebook.

@loicfavory
Copy link
Collaborator

I think you can only share a picture OR a link.
Facebook doesn't share text content.

For my project, I only need to share links, that why my fork ignore other parameters.

Maybe we could allow to share picture or link, but I think it can't be both.

@Stiofan
Copy link
Author

Stiofan commented Sep 17, 2015

Any update on this?

@issamdal
Copy link

Hello..I am using currently the plugin and sharing on facebook on android is important part of my app. will this issue be resolved soon? any workarounds? its a great plugin..I hope someone can help here

@loicfavory
Copy link
Collaborator

@leecrossley do you need help to solve this issue ?
I'm currently working on my project I could you some work for you if you need it.

@leecrossley
Copy link
Owner

Happy to take PRs

@loicfavory
Copy link
Collaborator

OK, seems there is a way to do it with picture & text using the Facebook SDK : http://stackoverflow.com/a/25065367
but I didn't test it, and will not have time now, but I'll work today on new branch to share only the URL as @nomaddevs asked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants