Need test for baseos image upgrade from within OCI image

[deitch]

Per the discussion here, as soon as that PR merges into eve, there will be support for getting a baseos image from within an OCI image. We should have a test for upgrading that way, in addition to the current.

@giggsoff and @sadov, can you point me to where the current baseos image upgrade tests are, and we can add another?

[sadov]

At the moment we have a such test to baseos image upgrade:
https://github.com/lf-edge/eden/blob/master/tests/update_eve_image/testdata/update_eve_image.txt

[deitch]

@sadov thanks for the pointer.

• What do we need to do to add an additional test? I am unsure how the whole test harness works, and what the minimum dependencies are for adding another test?
• More basically, should we be adding another test, e.g. tests/update_eve_image_oci, or is this another sub-test inside update_eve_image? How would we do that, if that is better?
• We would need to build an alternate image in docker and load it into the local registry (I sure am glad we have that now :-) ). How do we do that?

[giggsoff]

Hi, @deitch.
You can try to add your test into separate txt file here. You can take a look onto existing one and change steps of downloading and updating.
But before you do it, you should make sure, that Eden works well with something like ./eden controller edge-node eveimage-update oci://eve:version. If you will have problems on this check (manual one, not in test), feel free to open another issue.

Next, the problem here is in merging your future test and existing one into workflow. We should take into account on this step, that EVE have baseOS testing time. Probably, it will make sense to add some kind of teardown into existing test and future one, where we will ask EVE to return onto IMGA.

[deitch]

You can try to add your test into separate txt file here

What is the format of the txt file? Is it its own custom DSL? Or is it using some testing framework?

But before you do it, you should make sure, that Eden works well with something like ./eden controller edge-node eveimage-update oci://eve:version. If you will have problems on this check (manual one, not in test), feel free to open another issue.

It does work. For my test, I ran it with:

1. I built a new image locally, so it ended up in docker cache
2. I loaded it with eden registry ...
3. I updated with eden controller edge-node eveimage-update --registry=local oci://eve:version

I did this for 2 reasons:

• why hit the actual registry downloading it when unnecessary?
• the image needs to have the Dockerfile LABELs on them, or it won't work. We only added that a little over a week ago in this eve PR, so images on hub don't have them yet.

I think the right flow is as above, i.e. change something so we get a new version, build an image locally, load it to registry, then update.

How do we do that next?

[zed-sadov]

What is the format of the txt file? Is it its own custom DSL? Or is it using some testing framework?

This is a variant of the EDEN's Go script for writing tests -- Escript:
https://github.com/lf-edge/eden/blob/master/tests/README.md
https://github.com/lf-edge/eden/blob/master/tests/escript/README.md
which mainly uses EDEN commands and binary tests with a little glue logic around them.

[giggsoff]

Can we close this issue? Seems, it is resolved.