Peer discovery not working with mocknet on and go-multiaddr v0.12.4

[sstanculeanu]

Hello,

While trying to update our dependency of go-libp2p from v0.28.2 to v0.34.0(please find below a capture with old + new versions of the libs 👇 ), we noticed that the peer discovery does not work anymore with mocknet.

Digging a bit deeper, we localized the issue: it looks like the hardcoded ip6 multiaddr from GenPeerWithOptions is not compatible anymore with the latest release of go-multiaddr with the newly added ip6 restriction. isPublic is now always false here for the hardcoded address.

This leads to the multiaddr not being saved into the peerstore, thus peer discovery not working.

I've created a simple test in order to highlight the issue, which can be found on this repo.

Thanks

[sukunrt]

This will be fixed by v0.35.1
It's fixed on master by #2820

[sstanculeanu]

Re-tested with master branch, looks good, thank you 🙏

[sukunrt]

V0.35.1 is out!