Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown with simplified Collection doesn't render markup properly #5182

Closed
matuzalemsteles opened this issue Nov 7, 2022 · 1 comment · Fixed by #5183
Closed

DropDown with simplified Collection doesn't render markup properly #5182

matuzalemsteles opened this issue Nov 7, 2022 · 1 comment · Fixed by #5183
Assignees
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: bug Issues reporting that Component is not doing what should be done

Comments

@matuzalemsteles
Copy link
Member

We recently introduced the Collection pattern in DropDown #5101, there is a simplified composition for rendering the items in DropDown, which only needs to declare the Items as a child of the DropDown but that doesn't render the ItemList by default, causing it to break the markup and have accessibility issues as a result.

<ClayDropDown
  items={['one', 'two', 'three', 'four']}
  trigger={<ClayButton>Click Me</ClayButton>}
>
  {(item) => <ClayDropDown.Item key={item}>{item}</ClayDropDown.Item>}
</ClayDropDown>
@matuzalemsteles matuzalemsteles added type: bug Issues reporting that Component is not doing what should be done comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Nov 7, 2022
@matuzalemsteles matuzalemsteles self-assigned this Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-166807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
1 participant