Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-bourbon #1197

Open
3 tasks
Machacek76 opened this issue Mar 12, 2024 · 6 comments
Open
3 tasks

Upgrade node-bourbon #1197

Machacek76 opened this issue Mar 12, 2024 · 6 comments

Comments

@Machacek76
Copy link

Issue type (mark with x)

  • πŸ€” Question
  • [x ] πŸ› Bug report
  • 🎁 Feature request
  • πŸ€·β€β™€οΈ Other

Description

Current behavior:
could you update the dependency [email protected] which is 8 years old? And the build returns an error

Screenshot 2024-03-12 143214

@izaera
Copy link
Member

izaera commented Mar 13, 2024

Where's that? Type of project? Steps to reproduce? Is it a theme? πŸ€”

@Machacek76
Copy link
Author

Machacek76 commented Mar 13, 2024

We have a theme on LFR 7.3 and want to upgrade it to LFR 7.4. we proceed according to the instructions and we get this warning during the build.

https://learn.liferay.com/w/dxp/site-building/site-appearance/themes/upgrading-a-theme

Old Package
there use this npm package https://www.npmjs.com/package/node-bourbon?activeTab=dependencies

command
$ npm run build

package.json

{
	"name": "xxxx-theme",
	"version": "1.0.0",
	"main": "package.json",
	"keywords": [
		"liferay-theme"
	],
	"liferayTheme": {
		"baseTheme": "styled",
		"fontAwesome": false,
		"screenshot": "",
		"templateLanguage": "ftl",
		"version": "7.4"
	},
	"dependencies": {
		"gulp-include": "2.4.1",
		"gulp-uglify": "3.0.2",
		"@liferay/bs3-bs4-compat": "*"
	},
	"devDependencies": {
		"compass-mixins": "0.12.10",
		"gulp": "4.0.2",
		"gulp-include": "2.4.1",
		"gulp-uglify": "3.0.2",
		"liferay-frontend-theme-styled": "6.0.54",
		"liferay-frontend-theme-unstyled": "6.0.45",
		"liferay-theme-tasks": "^11.5.3",
		"liferay-frontend-css-common": "6.0.8"
	},
	"scripts": {
		"init": "gulp init",
		"build": "gulp build",
		"deploy": "gulp deploy",
		"extend": "gulp extend",
		"kickstart": "gulp kickstart",
		"status": "gulp status",
		"upgrade": "gulp upgrade",
		"watch": "gulp watch"
	}
}

Dependecies list

$ npm list --depth=1 
+-- @liferay/[email protected]
+-- [email protected]
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| `-- [email protected]
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| `-- [email protected]
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| `-- [email protected] deduped
+-- [email protected]
+-- [email protected]
+-- [email protected]
`-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected] deduped
  +-- [email protected]
  +-- [email protected]
  +-- [email protected] deduped
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected] deduped
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected] deduped
  +-- [email protected]
  +-- [email protected]
  `-- [email protected]

@izaera
Copy link
Member

izaera commented Mar 13, 2024

Oh, I see, so it's coming from liferay-theme-tasks not the theme itself...

However, I think it pulls it because it is used in DXP itself, not because the tool does something with it internally, so I cannot give you an answer.

@ethib137 is this something that can be updated or does it depend on DXP's target version? πŸ€”

@ethib137
Copy link
Member

@pat270 could you answer this? I think you know the context on this one, right?

@Machacek76
Copy link
Author

Any progress??

@pat270
Copy link
Member

pat270 commented Jun 4, 2024

Bourbon is a dependency of "liferay-frontend-css-common": "6.0.8". It contains our deprecated media query mixins from 6.2-7.0? I'm not exactly sure on the exact versions. You can remove that dependency in your package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants