Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][hlfir] No regressions on BLAS/LAPACK #64750

Closed
vzakhari opened this issue Aug 17, 2023 · 6 comments
Closed

[flang][hlfir] No regressions on BLAS/LAPACK #64750

vzakhari opened this issue Aug 17, 2023 · 6 comments
Assignees
Labels
flang:hlfir-switch Issues blocking Flang from switching to HLFIR lowering

Comments

@vzakhari
Copy link
Contributor

Part of https://discourse.llvm.org/t/rfc-enabling-the-hlfir-lowering-by-default/72778:

  • @kiranchandramohan: BLAS/LAPACK should continue to work. We are in the process of checking where we are with this.
@vzakhari vzakhari added the flang:hlfir-switch Issues blocking Flang from switching to HLFIR lowering label Aug 17, 2023
@kiranchandramohan kiranchandramohan self-assigned this Aug 18, 2023
@kiranchandramohan
Copy link
Contributor

HLFIR lowering looks OK for the BLAS/LAPACK version that we run downstream.
@h-vetinari @mmuetzel Would you like to see whether your changes for OpenBLAS (OpenMathLib/OpenBLAS#4016) work with HLFIR lowering (-flang-experimental-hlfir)?

@h-vetinari
Copy link
Contributor

I'm still stuck trying to get flang 17 to work on windows (spread over a couple of issues; most are referenced from conda-forge/flang-feedstock#28). I could build off of main with some effort, but I first want to be able to get flang 17 to compile a hello world on windows at all (help would be much appreciated...). Once that's done, I can easily throw it at various of our code bases, with or without -flang-experimental-hlfir.

The OpenBLAS folks were further along with this already, perhaps @martin-frbg (or @mmuetzel) could retry building OpenBLAS using a flang build off of main with -flang-experimental-hlfir.

@martin-frbg
Copy link

No difference in the LAPACK testsuite results from 17RC3 with and without -flang-experimental-hlfir on Skylake.

(There does however appear to be a regression in LLVM17's clang compilation of the AVX512 kernels for BLAS1 CASUM/ZASUM that looks similar to what Nvidia engineers found from their nvc OpenMathLib/OpenBLAS#4162 (comment) )

@kiranchandramohan
Copy link
Contributor

Thanks @martin-frbg @h-vetinari. I am closing this ticket as completed.

@h-vetinari
Copy link
Contributor

Thanks @martin-frbg!

There does however appear to be a regression in LLVM17's clang compilation of the AVX512 kernels for BLAS1 CASUM/ZASUM that looks similar to what Nvidia engineers found from their nvc xianyi/OpenBLAS#4162 (comment)

Worth another issue perhaps?

@martin-frbg
Copy link

Thanks @martin-frbg!

There does however appear to be a regression in LLVM17's clang compilation of the AVX512 kernels for BLAS1 CASUM/ZASUM that looks similar to what Nvidia engineers found from their nvc xianyi/OpenBLAS#4162 (comment)

Worth another issue perhaps?

Just for the record - this was now found to be caused by unsafe coding in OpenBLAS that just happened to work with gcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:hlfir-switch Issues blocking Flang from switching to HLFIR lowering
Projects
Development

No branches or pull requests

4 participants