magit-delta in forge

[kstatz12]

Is there a way to use magit-delta when reviewing pull requests?

[tarsius]

I have heard of magit-delta but haven't checked it out yet, so I don't know. The author of magit-delta, @dandavison is in a better position to answer that.

[kstatz12]

this is apparently the wrong place for this since its the downstream https://github.com/charignon/github-review that handles it.

[dandavison]

Hi @tarsius and @kstatz12.

@kstatz12 -- I have not yet tried using github-review to review PRs (and I'm not knowledgable about how it is related to forge / magit). From a technical point of view, magit-delta works by customizing the magit variable magit-diff-wash-diffs-hook and therefore as far as I know it should colorize any diff that magit displays, as long as magit calls magit-diff-wash-diffs on that diff. See magit/magit#4091 (comment) for the magit change that facilitated this.

If it doesn't seem to work but you feel that it should and you're able to give instructions for reproducing the issue, I'd happy to discuss it in a magit-delta issue.