Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapbox-gl-geocoder not compatible with [email protected] #528

Open
jeremy-wl-app-lite opened this issue Jul 10, 2024 · 6 comments
Open

Comments

@jeremy-wl-app-lite
Copy link

I'm migrating my project to mapbox-gl 3.5.1 but have hit a blocker

"dependencies": { "@mapbox/mapbox-gl-geocoder": "^5.0.2", "mapbox-gl": "^3.5.1", ... }, "devDependencies": { "@types/mapbox__mapbox-gl-geocoder": "^5.0.0", // I've tried building my project with this typing included as well as excluded }

When included, I get many errors. Here's 2 examples:

Example 1:
Error: node_modules/mapbox-gl/dist/mapbox-gl.d.ts:8293:2 - error TS2416: Property 'tileID' in type 'ImageSource' is not assignable to the same property in base type 'ISource'.
Type 'CanonicalTileID | null | undefined' is not assignable to type 'CanonicalTileID | undefined'.
Type 'null' is not assignable to type 'CanonicalTileID | undefined'.

8293 tileID: CanonicalTileID | null | undefined;

Example 2:
Error: node_modules/@types/mapbox__mapbox-gl-geocoder/index.d.ts:270:40 - error TS2694: Namespace '"C:/Users/.../app/node_modules/mapbox-gl/dist/mapbox-gl"' has no exported member 'FlyToOptions'.

270 setFlyTo(flyTo: boolean | mapboxgl.FlyToOptions | mapboxgl.FitBoundsOptions): this;

When excluded, I get many different errors. Here are examples:

Example 1:
Could not find a declaration file for module '@mapbox/mapbox-gl-geocoder'. 'c:/Users/.../app/node_modules/@mapbox/mapbox-gl-geocoder/lib/index.js' implicitly has an 'any' type.
Try npm i --save-dev @types/mapbox__mapbox-gl-geocoder if it exists or add a new declaration (.d.ts) file containing declare module '@mapbox/mapbox-gl-geocoder';ts(7016)

Example 2:
Error: src/app/services/map/layers/conditions.service.ts:238:133 - error TS2503: Cannot find namespace 'GeoJSON'.

238 private _getClosestFeature(point: LngLat, features: (GeoJSON.Feature & { geometry: { coordinates: [ number, number ][] } })[]): GeoJSON.Feature & { geometry: { coordinates: [ number, number ][] } } {

@manuelpoelzl
Copy link

Same here!

@utsabc
Copy link

utsabc commented Aug 11, 2024

Any updates here?

@JavierRomualdo
Copy link

Buen día, tengo el mismo problema:

image

Tal vez la versión mapbox-gl mayor a [3.5.1] ya no existe el type FlyToOptions, ya sea por alguna actualización

image

Cualquier aporte sería de útil para resolver
Gracias.

@Rubanrubi
Copy link

same issue @JavierRomualdo is this issue you fixed?

@Rubanrubi
Copy link

Rubanrubi commented Sep 4, 2024

This is the temporary solution currently i solved this by the below versions strictly installed version. @JavierRomualdo

"dependencies": {
"@mapbox/mapbox-gl-geocoder": "5.0.2",
"mapbox-gl": "3.0.1",
"ngx-mapbox-gl": "10.0.0",
},

"devDependencies": {
"@types/mapbox__mapbox-gl-geocoder": "5.0.0",
"@types/mapbox-gl": "2.7.19",
}

@ykulynych
Copy link

Another temporary solution is to disable the lib check in TypeScript's config. Just add the following line "skipLibCheck": true to compilerOptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants