MDCList performance patch for listElements() #8195
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes performance of complexity O(n^2) operations which call listElements() within a loop. See MDCListFoundation.getSelectedIndexFromDOM
which becomes noticeably slow once a list has several hundred items (e.g. a selection of countries) and unusable for several thousand items, forcing clients to implement measures against long lists which might not be feasible for them.