Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tax region + rates clean up #9279

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

fix: Tax region + rates clean up #9279

wants to merge 11 commits into from

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Sep 24, 2024 •
edited
Loading

What

  • Require code on Tax Rates

  • Update dashboard to account for non-nullable code on Tax Rates

  • Include automatic_taxes in API Route response

Closes CC-524 CC-525

@olivermrbl olivermrbl requested a review from a team as a code owner September 24, 2024 12:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8955769

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 7:07am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 7:07am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 7:07am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 7:07am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 7:07am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 7:07am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 7:07am

@olivermrbl olivermrbl mentioned this pull request Sep 24, 2024
Open
@olivermrbl olivermrbl mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermrbl @carlos-r-l-rodrigues