fix: validate regions exist for shipping option price update #9364
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
| ContainerRegistrationKeys.REMOTE_QUERY | ||
| ) | ||
|
|
||
| let remoteQueryObject = remoteQueryObjectFromString({ |
There was a problem hiding this comment.
Q: nothing to do but should we start using the query graph api instead when writing new things?
| if (!option.prices) { | ||
| return [] | ||
| } | ||
| return option.prices |
There was a problem hiding this comment.
Sug: return option.prices ?? []
| }) | ||
|
|
||
| const regionService = container.resolve(Modules.REGION) | ||
| const regionList = await regionService.listRegions({ |
There was a problem hiding this comment.
Sug: we should probably check the length before calling the service just as a best practice, i think we are handling it under the hood but if a module is replaced it might not always be the case wdyt? Also, it removes a call to the service and we can return early if there is nothing to check
What
updateShippingOptionsWorkflowandcreateShippingOptionsWorkflowthat validates if the region prices being updated have corresponding regions configured.Why
Fixes CC-542