Support replacing methods #4547
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check API changes are not detected in this pull request. |
jorgerangel-msft
force-pushed
the
replace-method-member
branch
2 times, most recently
from
b4b7d7c
to
c207660
Compare
jorgerangel-msft
changed the title
jorgerangel-msft
force-pushed
the
replace-method-member
branch
from
c207660
to
d118450
Compare
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| namespace Sample.Models | |||
| { | |||
| public partial class MockInputModel | |||
| public partial class Model | |||
There was a problem hiding this comment.
I was running into build errors on my local due to this file path being too long. There's probably another overall fix we can do for that, but for now I'm shortening the filename.
jorgerangel-msft
requested review from
m-nash and
JoshLove-msft
as code owners
| { | ||
| public static partial class SampleNamespaceModelFactory | ||
| { | ||
| public static MockInputModel MockInputModel(string prop1 = default, bool? optionalBool = default) |
There was a problem hiding this comment.
Can we also add a test case where we have a nullable struct, where the struct is generated by the library?
| } | ||
|
|
||
| string[] typeArguments = [.. namedTypeSymbol.TypeArguments.Select(GetFullyQualifiedName)]; | ||
| return $"{nullableTypeName}`{namedTypeSymbol.TypeArguments.Length}[{string.Join(", ", typeArguments)}]"; |
There was a problem hiding this comment.
Does the CSharpType we create from a symbol match the behavior for PropertyProvider.Type? I thought when creating CSharpType from the output types for a nullable, the CSharpType underlying Type would not be Nullable.
| @@ -286,14 +285,11 @@ private CSharpType GetCSharpType(ITypeSymbol typeSymbol) | |||
| Type? type = System.Type.GetType(fullyQualifiedName); | |||
| if (type is null) | |||
| { | |||
| if (typeSymbol.TypeKind == TypeKind.Error) | |||
| throw new InvalidOperationException($"Unable to convert ITypeSymbol: {fullyQualifiedName} to a CSharpType in {Name}"); | |||
|
|
|||
| return ConstructCSharpTypeFromSymbol(typeSymbol, fullyQualifiedName, namedTypeSymbol); | |||
There was a problem hiding this comment.
Since we now will fall back to constructing from the symbol, can we remove the if block that checks if the name starts with the RootNamespace?
There was a problem hiding this comment.
Nevermind, I don't think we want to do this as it will then attempt to look up generated types using GetType which would actually succeed if a custom partial class is added. But this would give us the wrong info for various properties of CSharpType.
This PR adds support for replacing generated methods with custom code. It also fixes several issues with constructing nullable types from custom code.
fixes: #4472