Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eio support #422

Open
madroach opened this issue Jul 30, 2023 · 2 comments
Open

Eio support #422

madroach opened this issue Jul 30, 2023 · 2 comments

Comments

@madroach
Copy link

Are there plans to implement conduit-eio ?

@ajbt200128
Copy link

Would be great to have EIO support from conduit with 5.2 released

@talex5
Copy link
Contributor

talex5 commented Jun 14, 2024

It might be good to rethink the design a bit before doing that. I'm always a bit confused by conduit, but it seems to provide three separate features:

  • An abstraction for byte streams (e.g. Conduit_lwt_unix.flow is a TCP socket, a Unix-domain socket, or a vchan).
  • Common APIs for tls and ssl, depending on what is installed.
  • A way to resolve endpoints into connections (with a fixed set of supported endpoint types).

Eio provides the Eio.Flow abstraction for byte streams, so possibly the first isn't needed.

In #420 (comment), @avsm said:

I'm tempted to suggest dropping support for the OpenSSL in Conduit

I'm not sure what uses the resolver. I'm also not sure how it works as e.g. the TLS endp variant doesn't contain any configuration settings (e.g. certificates and keys).

Perhaps we should start by making a list of features people want. Some things I'm interested in are:

  1. Adding TLS support to cohttp-eio without having to care about tls vs ssl.
  2. Having a common command-line syntax for saying where a service should listen (e.g. tcp:8080 or unix:/run/socket).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants