From 2472ba0ad0c979ddf463b7e7b6c12cff6f0e6307 Mon Sep 17 00:00:00 2001 From: David Sancho Moreno Date: Wed, 9 Aug 2023 14:00:01 +0200 Subject: [PATCH] Revert --- packages/belt/src/belt_Array.ml | 7 ++++--- packages/belt/src/belt_Array.mli | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/belt/src/belt_Array.ml b/packages/belt/src/belt_Array.ml index 5545195f2..1c3b74c1b 100644 --- a/packages/belt/src/belt_Array.ml +++ b/packages/belt/src/belt_Array.ml @@ -503,18 +503,19 @@ let reduceWithIndexU a x f = let reduceWithIndex a x f = reduceWithIndexU a x (fun a b c -> f a b c) -let joinWithU a sep = +let joinWithU a sep toString = match length a with | 0 -> "" | l -> let lastIndex = l - 1 in let rec aux i res = let v = getUnsafe a i in - if i = lastIndex then res ^ v else aux (i + 1) (res ^ v ^ sep) + if i = lastIndex then res ^ toString v + else aux (i + 1) (res ^ toString v ^ sep) in aux 0 "" -let joinWith a sep = joinWithU a sep +let joinWith a sep toString = joinWithU a sep (fun x -> toString x) let initU n f = Stdlib.Array.init n f let init n f = initU n (fun i -> f i) diff --git a/packages/belt/src/belt_Array.mli b/packages/belt/src/belt_Array.mli index c50a57c94..ca4ec0e54 100644 --- a/packages/belt/src/belt_Array.mli +++ b/packages/belt/src/belt_Array.mli @@ -549,9 +549,9 @@ val reduceWithIndex : 'a t -> 'b -> ('b -> 'a -> int -> 'b) -> 'b ]} *) -val joinWithU : string t -> string -> string +val joinWithU : 'a t -> string -> (('a -> string)[@bs]) -> string -val joinWith : string t -> string -> string +val joinWith : 'a t -> string -> ('a -> string) -> string (** [joinWith xs sep toString] Concatenates all the elements of [xs] converted to string with [toString], each separated by [sep], the string