From 4117f5971f761bd0ad2b34ff337e26c06496bdcd Mon Sep 17 00:00:00 2001 From: David Sancho Moreno Date: Wed, 2 Aug 2023 17:12:20 +0200 Subject: [PATCH] Fix Suspense --- packages/react/src/react.ml | 8 ++++++-- packages/react/src/react.mli | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/react/src/react.ml b/packages/react/src/react.ml index fb353657c..3ab2d2c41 100644 --- a/packages/react/src/react.ml +++ b/packages/react/src/react.ml @@ -205,8 +205,12 @@ let createContext (initial_value : 'a) : 'a context = { current_value = ref_value; provider; consumer } module Suspense = struct - let make ~fallback ~children = Suspense { fallback; children } -end [@react.component] + let or_react_null = function None -> null | Some x -> x + + let make ?fallback ?children () = + Suspense + { fallback = or_react_null fallback; children = or_react_null children } +end (* let memo f : 'props * 'props -> bool = f let memoCustomCompareProps f _compare : 'props * 'props -> bool = f *) diff --git a/packages/react/src/react.mli b/packages/react/src/react.mli index d6e05baba..009cf9fa2 100644 --- a/packages/react/src/react.mli +++ b/packages/react/src/react.mli @@ -90,7 +90,7 @@ type 'a context = { val createContext : 'a -> 'a context module Suspense : sig - val make : fallback:element -> children:element -> element + val make : ?fallback:element -> ?children:element -> unit -> element end type any_promise = Any_promise : 'a Lwt.t -> any_promise