Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace depriciated opCodes with OP_MSG and update associated wire protocol. #123

Closed
antarestrader opened this issue Jul 20, 2021 · 2 comments
Closed

Replace depriciated opCodes with OP_MSG and update associated wire protocol. #123

antarestrader opened this issue Jul 20, 2021 · 2 comments

Comments

@antarestrader
Copy link

mongodb/Database/MongoDB/Internal/Protocol.hs

Line 410 in 3bb466c

qOpcode :: Request -> Opcode

mongodb/Database/MongoDB/Internal/Protocol.hs

Line 330 in 3bb466c

nOpcode :: Notice -> Opcode

opCode values other than OP_MSG (2013) are depreciated starting with Version 5. Since version 3.6 OP_MSG has been the preferred request method.

putNotice and putRequest also need to be updtaed to match the OP_MSG wire protocol.

Doing so may partially or fully address issues #94, #97, #107, #112
@parsonsmatt parsonsmatt mentioned this issue Sep 12, 2022
Closed
@alexbevi alexbevi mentioned this issue Sep 21, 2022
Closed
@kfiz kfiz mentioned this issue Oct 9, 2022
Merged
@kfiz
Copy link
Contributor

kfiz commented Nov 5, 2022

@VictorDenisov I think this can be closed, as #137 was merged. Would you agree?

@VictorDenisov
Copy link
Member

Yep. Totally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antarestrader @VictorDenisov @kfiz