Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector] add method to get connected wallet checksum #181

Open
arobsn opened this issue Aug 7, 2024 · 1 comment
Open

[Connector] add method to get connected wallet checksum #181

arobsn opened this issue Aug 7, 2024 · 1 comment
Labels
dapp connector enhancement New feature or request

Comments

@arobsn
Copy link
Member

arobsn commented Aug 7, 2024

Exposing the wallet's name (as chosen by the user) can be considered a privacy violation in some cases, so exposing wallet's CIP-4 checksum sounds more appropriate here.

get_wallet_checksum(): { text: string, image: HexString }
@arobsn arobsn added enhancement New feature or request dapp connector labels Aug 7, 2024
@c8e4
Copy link

c8e4 commented Aug 7, 2024

As a user i never pay attention to those. Maybe it's time to introduce permissions? A dapp can reqest wallet name in the same screen as wallet selection.
Additional permissions like wallet name are checkboxes that can be explicitly checked! <- default unchecked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapp connector enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants