Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent initialization of MUSIC input proxies #3178

Open
heplesser opened this issue Apr 10, 2024 · 1 comment
Open

Inconsistent initialization of MUSIC input proxies #3178

heplesser opened this issue Apr 10, 2024 · 1 comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@heplesser
Copy link
Contributor

Of the four MUSIC input proxy models, music_{event,rate}_in_proxy register their default port with the MusicManager on construction of the model instance, but the cont and message proxies do not. This seems inconsistent and needs to be reviewed.
@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Apr 10, 2024
@heplesser heplesser mentioned this issue Apr 10, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Models
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heplesser