Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLog 4.5 support (.NET Standard 2 and structured logging) #159

Open
Troncek opened this issue Nov 13, 2017 · 4 comments
Open

NLog 4.5 support (.NET Standard 2 and structured logging) #159

Troncek opened this issue Nov 13, 2017 · 4 comments

Comments

@Troncek
Copy link

Troncek commented Nov 13, 2017

Any time-frame for NLog 4.5 wrapper in Common.Logging?

I can use the existing 4.4.12 and change it up a bit, and it works, but an official support would be nice.

Edit: Also, the NLog wrapper WriteInternal method that calls _logger.Log<> doesn't support structured logging functionality with NLog 4.5 beta7, because it fails in string.Format part of code in StringFormatFormattedMessage (AbstractLogger.cs).

@gaviriar
Copy link

Hi There, I would also be interested in support for NLog 4.5, is this planned at all?

@Troncek could you please share the code changes you have made?

@stevozilik
Copy link

I'm also interested in 4.5 support

@Seikilos
Copy link

@Troncek Could you create a pull request for your work? Even if it is a hack, this would allow the devs to review it. Looks like 4.5 is not going to be supported anytime soon here.

@snakefoot
Copy link

Created a pull-request: #176 (Includes custom build of nuget-package as attachment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants