Actuator endpoint naming for Spring Boot 3 #2077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
=========================================
Coverage 70.57% 70.58%
- Complexity 9875 9879 +4
=========================================
Files 829 829
Lines 39945 39960 +15
Branches 6078 6081 +3
=========================================
+ Hits 28191 28205 +14
Misses 9024 9024
- Partials 2730 2731 +1 ☔ View full report in Codecov by Sentry. |
meiao
reviewed
Sep 26, 2024
| // other than the first two, to prevent MGI for certain actuator endpoints. | ||
| // For example, "/actuator/loggers/com.newrelic" will be converted into | ||
| // "actuator/loggers" | ||
| String [] parts = uri.replaceFirst("^/", "").split("/"); |
There was a problem hiding this comment.
The replaceFirst method causes a regex to be compiled every time it is called.
uri.substring(uri.charAt(0) == '/' ? 1 : 0)
would have better performance.
.../boot/actuate/endpoint/web/servlet/AbstractWebMvcEndpointHandlerMapping_Instrumentation.java
Show resolved
Hide resolved
|
|
||
| if (transaction != null) { | ||
| String uri = SpringActuatorUtils.normalizeActuatorUri(request.getRequestURI()); | ||
| String reportablePrefix = SpringActuatorUtils.normalizeActuatorUri(uri); |
There was a problem hiding this comment.
won't this return the same string?
There was a problem hiding this comment.
Duh, yeah good catch, I left that in by accident when I did a refactor.
meiao
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming of actuator endpoints for Spring Boot 3
Resolves #2035
By default, built-in actuator endpoints and custom actuator endpoints (using the @endpoint annotation
and it's subclasses) will all be named as "OperationHandler/handle" in New Relic. Activating this
module will result in the transaction name reflecting the actual base actuator endpoint URI.
For example, invoking "/actuator/loggers" or "actuator/loggers/com.newrelic" will result in the
transaction name "actuator/loggers (GET)". This is to prevent MGI.
To activate actuator naming, set the following configuration to true:
class_transformer.name_actuator_endpointsThe default value is false.