enable fstrim by default #528
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zowoq
reviewed
Sep 29, 2024
| @@ -20,6 +20,10 @@ | |||
| enableNg = lib.mkDefault true; | |||
| }; | |||
|
|
|||
| # The majority of storage used for root filesystem is based on Sata SSD/NVMe, | |||
| # which benefits from enabling the periodic filesystem TRIM operation. | |||
| services.fstrim.enable = lib.mkDefault true; | |||
There was a problem hiding this comment.
Is this needed on zfs with zpool trim?
There was a problem hiding this comment.
We have a similar service called zpool-trim.service that is enabled by default.
However since it's just run once a week for less than a second, its basically free even if you don't need it, given the executable is also part of util-linux. Ubuntu does the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.