Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_headers_and_entries in nested region cannot find entries #62

Open
sklam opened this issue May 24, 2023 · 1 comment
Open

find_headers_and_entries in nested region cannot find entries #62

sklam opened this issue May 24, 2023 · 1 comment

Comments

@sklam
Copy link
Member

sklam commented May 24, 2023

Reproducer and SCFG rendering in https://gist.github.com/sklam/f43f7c4eb574a79eaca9d5b4d27ef6ba

When calling find_headers_and_entries in a header loop region that's inside a branch region, it fails to find the entry node.

The usecase is to insert a new block as the new header for the loop.

@kc611
Copy link
Contributor

kc611 commented May 25, 2023

I've put in a patch commit in #61 that 'fixes' this. (Finds entries outside of the region using regional hierarchy information).

Note that #61 changes a lot of things, and the equivalent of your insertion case would simply be reduced to adding a new header to the given region rather than trying to insert a new block between blocks spanning multiple regions. Since the regions are addressed by their own unique names, entries would point to the region instead of the block.

Would it be possible for you to try it out for your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants