Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in command behavior #4665

Open
nus-pe-bot opened this issue Apr 14, 2023 · 1 comment
Open

Inconsistency in command behavior #4665

nus-pe-bot opened this issue Apr 14, 2023 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 14, 2023

For regular fields like phone number, email and address, they are added with an ap command, edited with an ep command, and deleted with dp. However, for remark (which functions similar to tag), a separate remark command is used, and the adding, editing and deleting of that remark is all done within that single command. It might be confusing to users why this is so.


[original: nus-cs2103-AY2223S2/pe-interim#4663] [original labels: severity.High type.FeatureFlaw]
@runoutofit
Copy link
Contributor

Team's Response

firstly, this will not be confusing as this behaviour was clearly explained in the user guide to avoid confusion.

secondly, we decided to have a separate command for editing remarks instead of using ep, as remarks do not belong in the same class of atttributes as phone numbers, emails and addresses. not only can remarks be exceptionally long while phone numbers etc cant, they are also not intrinsic to a patient. patients will have phone numbers etc as their attributes but remarks are not compulsory. due to these reasons, we do not treat remarks the same way as other attributes of a patient, hence the rationale behind using a separate command.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants