Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with sequence diagram for view command #4671

Open
nus-pe-bot opened this issue Apr 14, 2023 · 1 comment
Open

Issue with sequence diagram for view command #4671

nus-pe-bot opened this issue Apr 14, 2023 · 1 comment
Labels
response.Accepted severity.Low status.Done team.4 tutorial.CS2103T-W12 type.DocumentationBug

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 14, 2023 •
edited by runoutofit
Loading

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png

Since the arrow from addressbookparser to view command points to the name of viewcommand, one would think that it is calling the constructor. Thus, shouldn't the box be attached to the viewcommand class name?

On further inspection, the same issue can be applied to the sequence diagram of other commands as well.

[original: nus-cs2103-AY2223S2/pe-interim#4671] [original labels: severity.Low type.DocumentationBug]
@runoutofit
Copy link
Contributor

runoutofit commented Apr 17, 2023 •
edited
Loading

Team's Response

No details provided by team.

Duplicate status (if any):

--

@runoutofit runoutofit assigned runoutofit and unassigned runoutofit Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
response.Accepted severity.Low status.Done team.4 tutorial.CS2103T-W12 type.DocumentationBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nus-pe-bot @runoutofit