Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pong messages to follow the graphql websocket protocol. #116

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix pong messages to follow the graphql websocket protocol. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d79c346
Fix pong messages to follow the graphql websocket protocol.
vorporeal Aug 9, 2024
f6f39a0
Update CHANGELOG.md.
vorporeal Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@ all APIs might be changed.

## Unreleased

### Bug Fixes

- Fixed ping responses not following the graphql-transport-ws protocol
([#116](https://github.com/obmarg/graphql-ws-client/pull/116))

### Contributors

Thanks to the people who contributed to this release:

- @vorporeal

## v0.10.1 - 2024-06-08

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion src/next/actor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ impl ConnectionActor {
None
}
Event::ConnectionAck { .. } => Some(Message::close(Reason::UnexpectedAck)),
Event::Ping { .. } => Some(Message::Pong),
Event::Ping { .. } => Some(Message::graphql_pong()),
Event::Pong { .. } => None,
}
}
Expand Down