-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: obs-crowdin-sync Python Rewrite #10578
base: master
Are you sure you want to change the base?
Conversation
290ebb4
to
cf44fa4
Compare
cf44fa4
to
5ab2c6a
Compare
Blocked by #10658, once merged please update your code to only translate The latter is in the deprecated CMake path, the former is the new one. |
@tytan652 Should it also update |
5ab2c6a
to
26c8997
Compare
Yes I think the change about going away from xdg-data folder has completely gone unseen. We found out about it recently through metainfo regression in CI. |
Ready for review. |
26c8997
to
50034b9
Compare
e3cdf88
to
5187ace
Compare
5187ace
to
e95c701
Compare
Description
Rewrites the obs-crowdin-sync repository in Python and adds the action to this repository.
Changes that come along with it:
UI/cmake/linux/com.obsproject.Studio.metainfo.xml.in
file.English
toEnglish (USA)
foren-US
.UI/data/locale.ini
.Language
string in a separateLanguage Name
file on Crowdin, remove it here.Makes the organization/repository secret
CROWDIN_SYNC_GITHUB_PAT
obsolete.Motivation and Context
The obs-crowdin-sync repository was too much for what it solves.
This solution is better for integration testing, easier to extend, easier for error analysis in the log because you don't have a huge bundled script and much cleaner to look at.
Pushing directly to the repo is bad, creating a PR is safer and transparent.
How Has This Been Tested?
Locally and Vainock#3. The
update-crowdin-locales
action was tested in a obs-studio and obs-browser fork.Types of changes
Checklist: