-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Minor update of build scripts and GitHub Actions workflows and actions #11282
Conversation
1140aa3
to
5bf1c79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to pinned third-party actions look fine. The changes to Zsh and Ubuntu version requirements look fine. The documentation updates are largely fine. I don't know if anyone will have opinions about the other changes, but I'll let it sit at least overnight.
5bf1c79
to
059dce5
Compare
059dce5
to
9f9a3d5
Compare
If you are on it, could you take a look at why obs-studio/.github/workflows/scheduled.yaml Line 135 in 61d74fb
This line was changed by #11253. |
That's because the check never ran, so there is no In theory we could use
|
Once upon a time there was the idea to enable use of Ccache for Windows builds on CI as well, but to achieve this the project would need to switch to clang-cl.exe as its compiler and use an additional post-build step to generate PDBs from binaries. Using a different compiler for continuous integration than for building release builds defeats the purpose of CI however, so the idea was dropped.
Also defaults to Qt6 and x86_64 builds, thus no toolchain file is needed and no additional data in buildspec is needed either.
9f9a3d5
to
9839bca
Compare
Description
Updates the following aspects of the current build scripts and GitHub Actions workflows and actions:
qt-xml-validator
now uses thecheck-changes
action to check for and get a list of changed UI filessparkle-appcast
action have been updated with doc comments to explain how they work (XSLT and XPATH are remnants of a past age of Java, SOAP, and XHTML, so not many might be familiar with these)sphinx-publish-action
has been updated to use the precise commit hash of version 1.2.0wrangler-action
has been updated to commit hash of version 3.7.0Motivation and Context
Regular maintenance of CI workflows and build scripts.
How Has This Been Tested?
Will need some actual CI runs to test.
Types of changes
Checklist: