Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Fix source profiling inactive sources #11315

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented Sep 25, 2024

Description

fix source profiling inactive sources

Motivation and Context

When filters are disabled the tick takes time, but the cpu and gpu render do not, so I would like to see that in profiler_result_t.
Before it would show the last status before it was disabled, now the cpu and gpu go to 0 in 5 seconds

How Has This Been Tested?

With https://github.com/exeldro/obs-source-profiler by enabling and disabling a filter.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@exeldro exeldro changed the title libobs: fix source profiling inactive sources libobs: Fix source profiling inactive sources Sep 26, 2024
Copy link
Member

@derrod derrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think originally I did it this way to avoid a bit of overhead for inactive sources and then just hide stuff in the UI, but I suppose this also makes sense.

BTW if you release https://github.com/exeldro/obs-source-profiler it would be nice to be credited since it seems to be based on my original UI prototype branch :)

@exeldro
Copy link
Contributor Author

exeldro commented Sep 26, 2024

@derrod I made your source profiler UI code into a plugin and changed some things to make testing easier for me. I now updated the readme to credit you. I will not make releases for mine if you plan to release a plugin yourself. Otherwise I will also credit you on the OBS forum resource page.

@derrod
Copy link
Member

derrod commented Sep 26, 2024

@derrod I made your source profiler UI code into a plugin and changed some things to make testing easier for me. I now updated the readme to credit you. I will not make releases for mine if you plan to release a plugin yourself. Otherwise I will also credit you on the OBS forum resource page.

Ab I see. I still plan on releasing a standalone plugin once 31.0 beta is out, but wouldn't mind somebody else also releasing a version with improved UI 😅

@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Sep 26, 2024
@RytoEX RytoEX added this to the OBS Studio 31 milestone Sep 26, 2024
@RytoEX RytoEX merged commit de2f1fc into obsproject:master Sep 26, 2024
14 checks passed
@exeldro exeldro deleted the source_profile_fix_disabled branch September 27, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants