Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ppxlib's label exposed #481

Open
davesnx opened this issue Mar 9, 2024 · 1 comment
Open

Remove Ppxlib's label exposed #481

davesnx opened this issue Mar 9, 2024 · 1 comment
Assignees

Comments

@davesnx
Copy link
Contributor

davesnx commented Mar 9, 2024

There seems to be a type "label" assigned to string which messes a bit with error messages and inference when you use ppxlib with open Ppxlib. Is there any chance to fix it?

I endup doing a workaround like (unsure if there's a better way)

type s = string
open Ppxlib
type string = s
@NathanReb
Copy link
Collaborator

I agree this is annoying but it comes from the Asttypes that are in scope when opening Ppxlib. We obviously can't remove them from the scope as it would be a huge breaking change.

I'll try to see if we can incorporate a similar trick to yours directly into ppxlib.

@NathanReb NathanReb self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants